Automatic subscription to maintained packages #655
Merged
+351
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florentc
force-pushed
the
fix-647-auto-notification-maintainers
branch
from
3df3498 to
08bafbd
Compare
florentc
force-pushed
the
fix-647-auto-notification-maintainers
branch
from
08bafbd to
652cd31
Compare
YorikSar
reviewed
Nov 17, 2025
src/shared/listeners/notify_users.py
Outdated
| notification_reason = [] | ||
|
|
||
| # Check if user is subscribed to any affected packages | ||
| if user in subscribed_users: |
There was a problem hiding this comment.
Note that subscribed_users here is a list, which would make this and the ckeck o line 91 a bottleneck for popular packages.
src/shared/listeners/notify_users.py
Outdated
| if maintainers_github: | ||
| maintainer_users = set( | ||
| User.objects.filter( | ||
| username__in=maintainers_github, |
There was a problem hiding this comment.
Would it be better to have another JOIN here instead of fetching all GitHub handles into Python just to send them back?
src/webview/subscriptions/views.py
Outdated
| if action == "enable": | ||
| if profile.auto_subscribe_to_maintained_packages: | ||
| return self._handle_error( | ||
| request, "Auto-subscription is already enabled." |
There was a problem hiding this comment.
I don't think this should be an error: if response to one query was lost and user clicked on the button twice, it should still be fine as long as we reach expected state.
florentc
force-pushed
the
fix-647-auto-notification-maintainers
branch
from
e3e4aac to
82ee088
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #647.
This feature introduces a toggle (by default on) to be notified about new suggestions involving packages a user maintains, even if they have not manually added it in the subscriptions center.
Notifications mention that you are notified because you are a maintainer
